Skip to content

Conversation

eddumelendez
Copy link
Contributor

Allow to customize the failure handler.

Fixes gh-7051

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 4, 2019
@eddumelendez
Copy link
Contributor Author

@rwinch I tried to write a test but had not success. Can you give me a hint?

Thanks in advance

@jgrandja
Copy link
Contributor

jgrandja commented Jul 5, 2019

@eddumelendez The changes should be very similar to this commit and associated issue.

Can you be more specific on the problem you are having?

@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 5, 2019
@jgrandja jgrandja self-assigned this Jul 5, 2019
@eddumelendez eddumelendez force-pushed the gh-7051 branch 2 times, most recently from bb47e81 to 0fe26f9 Compare July 21, 2019 05:40
@eddumelendez eddumelendez marked this pull request as ready for review July 21, 2019 06:50
@eddumelendez
Copy link
Contributor Author

@jgrandja I could add the test and now my PR is ready to be reviewed.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 29, 2019
@rwinch rwinch assigned rwinch and unassigned jgrandja Aug 5, 2019
@rwinch rwinch added in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: feedback-provided Feedback has been provided in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Aug 5, 2019
@rwinch rwinch added this to the 5.2.0.RC1 milestone Aug 5, 2019
@rwinch rwinch merged commit 2c836a1 into spring-projects:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OAuth2LoginSpec.authenticationFailureHandler
4 participants