Skip to content

Conversation

larsgrefer
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 9, 2019
build.gradle Outdated
@@ -3,7 +3,7 @@ buildscript {
classpath 'io.spring.gradle:spring-build-conventions:0.0.23.RELEASE'
classpath "org.springframework.boot:spring-boot-gradle-plugin:$springBootVersion"
classpath 'io.spring.nohttp:nohttp-gradle:0.0.2.RELEASE'
classpath "io.freefair.gradle:aspectj-plugin:4.0.1"
classpath "io.freefair.gradle:aspectj-plugin:4.0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsgrefer is this necessary in order to upgrade the Gradle version?

To keep consistent with our team's pattern for doing upgrades, would you you please put this on a separate ticket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzheaux No, its not strictly necessary.

I'll split this into two PR's

@jzheaux jzheaux merged commit 7c30076 into spring-projects:master Sep 12, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Sep 12, 2019

Thanks, @larsgrefer! This is now merged into master.

And thank you for the extra work to split these into separate PRs.

@jzheaux jzheaux added in: build An issue in the build type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 12, 2019
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 12, 2019
@jzheaux jzheaux self-assigned this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants