Make saveAuthorizedClient save the authorized client #7551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, saveAuthorizedClient never actually saved the authorized client, because it ignored the Mono<Void> returned from authorizedClientRepository.saveAuthorizedClient. Now, it does not ignore the Mono<Void> returned from authorizedClientRepository.saveAuthorizedClient, and includes it in the stream, and therefore it will properly save the authorized client. Fixes gh-7546
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
added
in: oauth2
|
Thank you for catching that @philsttr and for providing the fix. This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
DefaultReactiveOAuth2AuthorizedClientManager.saveAuthorizedClientactually save the authorized clientPreviously,
saveAuthorizedClientnever actually saved the authorized client, because it ignored theMono<Void>returned fromauthorizedClientRepository.saveAuthorizedClient.Now, it does not ignore the
Mono<Void>returned fromauthorizedClientRepository.saveAuthorizedClient, and includes it in the stream, and therefore it will properly save the authorized client.Added logic to unit test to verify the
Mono<Void>returned fromauthorizedClientRepository.saveAuthorizedClientis subscribed.Fixes gh-7546
I have signed the CLA