Set credentials charset of authentication converter #7846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterkeller Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@peterkeller Thank you for signing the Contributor License Agreement! |
eleftherias
suggested changes
Jan 22, 2020
There was a problem hiding this comment.
Thanks for the PR @peterkeller! I have left some comments inline.
...java/org/springframework/security/web/authentication/www/BasicAuthenticationFilterTests.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/security/web/authentication/www/BasicAuthenticationFilterTests.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/security/web/authentication/www/BasicAuthenticationFilterTests.java
Outdated
Show resolved
Hide resolved
eleftherias
added
in: web
|
Thanks for the PR @peterkeller! This is now merged into master and backported to 5.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7835 including unit tests