Skip to content

Documented dependencies for opaque Resource Server #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

pgerhard
Copy link
Contributor

As discussed in #8391, extended the documentation for the opaque Resource Server in order to clearly state which dependencies are required in order for the minimal deployment to work.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 15, 2020
@rwinch rwinch self-assigned this Apr 16, 2020
@rwinch rwinch added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2020
@rwinch
Copy link
Member

rwinch commented Apr 16, 2020

Thanks for the PR @pgerhard! Could you please update the commit to match our Contributor guidelines. In particular it should end with an empty new line and then Closes gh-8391

@rwinch rwinch added the status: waiting-for-feedback We need additional information before we can continue label Apr 16, 2020
@pgerhard
Copy link
Contributor Author

@rwinch oops. Sorry I will get right on that. While doing this I just noticed that the link to the Contributor guidelines in the README.md is dead. Can I fix this in the PR or do we need an extra ticket?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 17, 2020
Extended the documentation for the opaque Resource Server in order to clearly state which dependencies are required in order for the minimal deployment to work. Replaced dead link for Contribute guidelines in README.adoc

Closes spring-projectsgh-8391
@rwinch
Copy link
Member

rwinch commented Apr 17, 2020

@pgerhard Ahh good catch. Please send a separate PR for that.

@rwinch rwinch added this to the 5.4.0.M1 milestone Apr 17, 2020
@rwinch rwinch merged commit b9b8903 into spring-projects:master Apr 17, 2020
@rwinch
Copy link
Member

rwinch commented Apr 17, 2020

I just went ahead and merged. Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants