Skip to content

Fix mismatch between CONTRIBUTING.adoc and .editorconfig #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

VonUniGE
Copy link

In CONTRIBUTING.adoc, we have:

Latin-1 (ISO-8859-1) encoding for Java sources; use native2ascii to convert if necessary

In .editorconfig, we have:

 charset = utf-8

Both files were in sync, but apparently this commit which converted Contribution.md to Contributing.adoc, did not use the latest version and some modifications have been lost.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 19, 2020
@rwinch rwinch added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 20, 2020
@rwinch rwinch self-assigned this Apr 20, 2020
@rwinch rwinch added this to the 5.4.0.M1 milestone Apr 20, 2020
@rwinch rwinch merged commit a88c771 into spring-projects:master Apr 20, 2020
@rwinch
Copy link
Member

rwinch commented Apr 20, 2020

Thanks for the Pull Request! This is now merged into master 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants