Skip to content

Conversation

omlip
Copy link

@omlip omlip commented Nov 23, 2020

Fix #9212

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2020
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2020
@jzheaux jzheaux added this to the 5.5.0-M2 milestone Nov 25, 2020
@jgrandja jgrandja assigned jzheaux and unassigned jgrandja Nov 26, 2020
@omlip
Copy link
Author

omlip commented Dec 1, 2020

@jzheaux It seems I did something wrong using Git (I rebase against master) this is why we have all the commits in this.

I guess it is not so evident to review this actually. Do we leave this PR as it is or I create a new one and we close/archive this one ?

@jzheaux
Copy link
Contributor

jzheaux commented Dec 1, 2020

I think if you do a rebase, it will resolve the issue. If we imagine your fork is called origin and this is called spring-projects, you can do the following:

git checkout master
git reset --hard spring-projects/master
git pull spring-projects master
git checkout issues/9212
git rebase master
git push origin +issues/9212

@jzheaux
Copy link
Contributor

jzheaux commented Dec 1, 2020

Thanks, @omlip! In preparation for merging, will you please squash your four commits into one and ensure that the resulting commit message contains the phrase "Closes gh-9212"?

@omlip
Copy link
Author

omlip commented Dec 1, 2020

Sure

@jzheaux jzheaux merged commit 808b8c3 into spring-projects:master Dec 2, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Dec 2, 2020

Thanks, @omlip! This is now merged into master.

@jzheaux jzheaux changed the title Avoid ClassCastException if principalClaim value is not a … Improve handling of non-String principal claim values Dec 2, 2020
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of non-String principal claim values
4 participants