Fixed NullPointerException with WWW-Authenticate #9303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
tristanexsquare
force-pushed
the
master
branch
from
2a40bba to
e8e88eb
Compare
Tusenka
approved these changes
Dec 22, 2020
jzheaux
requested changes
Jan 5, 2021
| @@ -70,7 +70,7 @@ private OAuth2Error readErrorFromWwwAuthenticate(HttpHeaders headers) { | |||
| return null; | |||
| } | |||
| BearerTokenError bearerTokenError = getBearerToken(wwwAuthenticateHeader); | |||
| String errorCode = (bearerTokenError.getCode() != null) ? bearerTokenError.getCode() | |||
| String errorCode = (bearerTokenError != null && bearerTokenError.getCode() != null) ? bearerTokenError.getCode() | |||
There was a problem hiding this comment.
This doesn't appear to address the issue completely since bearerTokenError is referred to later on in the method, potentially causing more NPEs.
If wonder if it would be better to do:
if (bearerTokenError == null) {
return new OAuth2Error(OAuth2ErrorCodes.SERVER_ERROR, null, null);
}
String errorCode = ...There was a problem hiding this comment.
That's a good point. I will do that.
jzheaux
added
in: oauth2
jzheaux
added
the
status: waiting-for-feedback
|
Hi, @tristanessquare! Are you able to make the requested changes? |
tristanexsquare
force-pushed
the
master
branch
from
e8e88eb to
ab60faa
Compare
|
Thanks, @tristanessquare! I think the changes make sense. Since this is addressing a bug, would you please also add a test to |
tristanexsquare
force-pushed
the
master
branch
from
ab60faa to
d6bfc7c
Compare
tristanexsquare
force-pushed
the
master
branch
from
d6bfc7c to
0ad5b44
Compare
jzheaux
approved these changes
Jan 21, 2021
|
Thanks for the PR, @tristanessquare! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed possible NullPointerException that happens when the OAuth2 ResourceServer does not return a valid WWW-Authenticate header format.