Skip to content

webflux oauth2Login with formLogin test #9318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

webflux oauth2Login with formLogin test #9318

wants to merge 4 commits into from

Conversation

iilkevych
Copy link

this is just test to answer question in
#6802 (comment)

also this would be valid scenario for
#9299

@pivotal-issuemaster
Copy link

@iilkevych Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@iilkevych Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 30, 2020
@jgrandja
Copy link
Contributor

jgrandja commented Jan 4, 2021 •
edited
Loading

@iilkevych

this is just test to answer question in
#6802 (comment)

gh-6802 is related to the Servlet implementation, however, the test in this PR is associated to the WebFlux implementation.

Is there a specific bug (in the WebFlux implementation) that needs to be fixed that is associated to the test in this PR?

@jgrandja jgrandja self-assigned this Jan 4, 2021
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 4, 2021
@iilkevych
Copy link
Author

iilkevych commented Jan 4, 2021 •
edited
Loading

@jgrandja
This test shows that problem is only in Servlet. WebFlux handles oauth2Login with formLogin without any issues unless this test fails.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 4, 2021
@jgrandja
Copy link
Contributor

jgrandja commented Jan 5, 2021

@iilkevych

This test shows that problem is only in Servlet

The test in this PR is WebFlux, given that the configuration uses ServerHttpSecurity

It doesn't demonstrate the issue in the Servlet implementation.

WebFlux handles oauth2Login with formLogin without any issues unless this test fails.

I'm going to close this PR since there is no issue with the WebFlux implementation.

@jgrandja jgrandja closed this Jan 5, 2021
@jgrandja jgrandja added status: invalid An issue that we don't feel is valid and removed status: feedback-provided Feedback has been provided labels Jan 5, 2021
@iilkevych iilkevych mentioned this pull request Jan 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iilkevych @pivotal-issuemaster @jgrandja @spring-projects-issues