-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Fix beanResolver missing in CurrentSecurityContextArgumentResolver. #9331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@happier233 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@happier233 Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, @happier233! Would you please add a test that demonstrates that beanResolver
is now getting used?
@happier233 are you able to make the requested changes to your PR? |
083de60
to
49fbcd7
Compare
@jzheaux I'm very sorry for costing many days to add the test to the PR, but I don't know where the code in my PR caused the format error. |
No problem, @happier233. I've merged your changes in 873b9bd and polished it in 107f38f. In the future, you can run |
CurrentSecurityContextArgumentResolver has 'beanResolver' property, but never used. I think it might be missed.
I test the AuthenticationPrincipal annotation and CurrentSecurityContext annotation, CurrentSecurityContext annotation expression cannot work with bean.