Skip to content

Add actuator endpoint to find and delete sessions #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

  • I have signed the CLA

See gh-407

@eddumelendez eddumelendez force-pushed the gh-407 branch 2 times, most recently from 4b9e423 to 958954b Compare April 12, 2016 11:29
*
* @author Eddú Meléndez
* @since 1.2.0
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use @ConfigurationProperties here and make sensible and path configurable?

@vpavic
Copy link
Contributor

vpavic commented Apr 12, 2016

@eddumelendez This is a very useful addition however IMO it should be targeted at Spring Boot since first-class Spring Session integration already exists there.

WDYT @rwinch?

@rwinch rwinch added this to the 1.3.0 M1 milestone Apr 14, 2016
@rwinch
Copy link
Member

rwinch commented Apr 14, 2016

@vpavic @eddumelendez I do think it may be better fit for Spring Boot as this is where most actuator endpoints live.

@vpavic
Copy link
Contributor

vpavic commented Apr 14, 2016

@rwinch Also I don't think it's a wise idea to have a dependency on Boot (other than in sample apps that is).

Since Boot's POM actually provides the dependency management for Session that would effectively create a circular dependency between the projects.

@cemo
Copy link

cemo commented Apr 15, 2016

+1 @vpavic

@eddumelendez
Copy link
Contributor Author

Thanks guys for the feedback I will move my changes to spring-boot project... Hope to see all new improvements there soon.

@eddumelendez
Copy link
Contributor Author

Close in favor of spring-projects/spring-boot#5730

@rwinch rwinch removed this from the 1.3.0 M1 milestone Sep 14, 2016
@rwinch rwinch self-assigned this Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants