Skip to content

Handling CommandNotFound exceptions #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhomble opened this issue Dec 18, 2019 · 0 comments
Closed

Handling CommandNotFound exceptions #293

nhomble opened this issue Dec 18, 2019 · 0 comments
Milestone
2.1.0-M2

Comments

@nhomble
Copy link
Contributor

nhomble commented Dec 18, 2019

It seems limiting that when a CommandNotFound is determined by Shell this ultimately will fail to match with any ResultHandlers and we'll just error out.
I think it would be really helpful if users could define their own CommandNotFoundResultHandler to match on these misses and allow for some default action. I think we have all the machinery to do this now, but

private final List<String> words;

has no getter.. so I am thinking we just expose this?
nhomble added a commit to nhomble/spring-shell that referenced this issue Dec 18, 2019
@nhomble
spring-projectsgh-293
d40218c 
expose words for end users to take some default action
@jvalkeal jvalkeal added this to the 3.0.0-M2 milestone Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0-M2
Development

No branches or pull requests
2 participants
@jvalkeal @nhomble