Skip to content

Refactor ResultHandler type hierachy #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvalkeal opened this issue Dec 21, 2021 · 0 comments
Closed

Refactor ResultHandler type hierachy #336

jvalkeal opened this issue Dec 21, 2021 · 0 comments
Milestone

Comments

@jvalkeal
Copy link
Contributor

On big issue with a result handling is that there is a ResultHandler and then thigns are interconnected in other handlers i.e. having main handler as TypeHierarchyResultHandler, etc.

Come up with new ResultHandlerService which can be designed in a way by taking a lot of concepts from framework ConversionService.

@jvalkeal jvalkeal added this to the 3.0.0-M1 milestone Dec 21, 2021
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Dec 21, 2021
- Replace main use of ResultHandler with ResultHandlerService which is
  a framework type of impl for handlers found from conversion service.
  This handles types better and easier to handle with bean cycles, etc.
- Removed IterableResultHandler to think about these use cases later
  when further refactoring is done.
- TypeHierarchyResultHandler is removed and better functionality now
  via ResultHandlerService.
- Relates spring-projects#336
jvalkeal added a commit that referenced this issue Dec 21, 2021
- Replace main use of ResultHandler with ResultHandlerService which is
  a framework type of impl for handlers found from conversion service.
  This handles types better and easier to handle with bean cycles, etc.
- Removed IterableResultHandler to think about these use cases later
  when further refactoring is done.
- TypeHierarchyResultHandler is removed and better functionality now
  via ResultHandlerService.
- Relates #336
@jvalkeal jvalkeal closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant