Skip to content

Change or remove group of "Built-in Commands" #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhait opened this issue Jan 14, 2022 · 2 comments · Fixed by #355
Closed

Change or remove group of "Built-in Commands" #347

dhait opened this issue Jan 14, 2022 · 2 comments · Fixed by #355
Labels
type/enhancement Is an enhancement request
Milestone
2.1.0-M2

Comments

@dhait
Copy link

dhait commented Jan 14, 2022

When the user types "help", the Built-In Commands are always shown as a separate group, followed by a group of my own commands (named after the class they are in).

I would like to see all the commands together, with no distinction. But there doesn't appear to be a way to "ungroup" all the commands, or alternatively merge the groups together.

Can we get some more flexibility on the Built-In commands (short of having to redefine every one of them)?
@jvalkeal jvalkeal added the type/enhancement Is an enhancement request label Jan 18, 2022
@jvalkeal
Copy link
Contributor

Yes I've also felt that being a bit annoying. We could try to allow defining on what group those belong to and then going even further and omitting group name if there's only one.

@jvalkeal jvalkeal added this to the 3.0.0-M2 milestone Jan 24, 2022
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Jan 24, 2022
@jvalkeal
Make grouping configurable in build-in help
e45ed7b 
- New option spring.shell.command.help.grouping-mode which can be either flat/group.
- Build-in help command can now choose if to group command or just show flat list.
- Fixes spring-projects#347
@jvalkeal jvalkeal mentioned this issue Jan 24, 2022
Merged
@jvalkeal
Copy link
Contributor

@dhait Would you be happy with changes in a PR?

jvalkeal added a commit that referenced this issue Feb 1, 2022
@jvalkeal
Make grouping configurable in build-in help
9ec5ffa 
- New option spring.shell.command.help.grouping-mode which can be either flat/group.
- Build-in help command can now choose if to group command or just show flat list.
- Fixes #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Is an enhancement request
Projects
None yet
Milestone
2.1.0-M2
Development

Successfully merging a pull request may close this issue.

Make grouping configurable in build-in help jvalkeal/spring-shell
2 participants
@jvalkeal @dhait