You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not sure if ERROR is the appropriate log level. Maybe change to WARNING or find a more compact way to express that no data exists for a version string. Or maybe don't activate the version command if the properties are not set.
The text was updated successfully, but these errors were encountered:
You're right that it's not an error as we know stringtemplate from antlr will report those as errors. We added that listener as otherwise antlr printed those into stderr. We could set attributes to nulls and also tweak logging levels.
jvalkeal
added a commit
to jvalkeal/spring-shell
that referenced
this issue
Feb 11, 2022
- Now passing version command attributes
even if those are nulls(not set) as ST
logs those in a listener as errors while
it doesn't cause any failures.
- Change all LoggingSTErrorListener methods
into debug level to limit more noise.
- Fixesspring-projects#363
- Now passing version command attributes
even if those are nulls(not set) as ST
logs those in a listener as errors while
it doesn't cause any failures.
- Change all LoggingSTErrorListener methods
into debug level to limit more noise.
- Fixes#363
Uh oh!
There was an error while loading. Please reload this page.
By default, the
version
command is active. However, without any properties set, the output mightsurprise:
I am not sure if ERROR is the appropriate log level. Maybe change to WARNING or find a more compact way to express that no data exists for a version string. Or maybe don't activate the
version
command if the properties are not set.The text was updated successfully, but these errors were encountered: