Skip to content

CommandRegistration beans should be "optional" #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvalkeal opened this issue May 6, 2022 · 1 comment
Open

CommandRegistration beans should be "optional" #399

jvalkeal opened this issue May 6, 2022 · 1 comment

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented May 6, 2022

As with #380 command registrations more fully dynamic and user can just define CommandRegistration as a bean it might be beneficial to allow user to define when to register those beans.

Use case for not to automatically register CommandRegistration as a bean might be that you still want those as a bean in an application context(possibly handling registration manually). Maybe some annotations to disable registrations or settings in a autoconfiguration or something similar.

@jvalkeal jvalkeal added this to the 2.1.0-M4 milestone May 6, 2022
@jvalkeal jvalkeal modified the milestones: 2.1.0-M4, 2.1.0-RC1 May 14, 2022
@jvalkeal jvalkeal modified the milestones: 2.1.0-RC1, General Backlog Jun 1, 2022
@Koooooo-7
Copy link

Hi @jvalkeal , I m wondering what means the optional? If user register CommandRegistration in a @Bean way, they already have the @ConfitionalOnXXX to control those beans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants