-
Notifications
You must be signed in to change notification settings - Fork 395
Rework command subsystem #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This turned out to be a relatively major work so it is unrealistic to do it with |
Just wanted to give update on this as I've been doing a major refactoring and re-work so there might be a time to push this work into |
- Focus of these changes are to introduce a new command system based on real registrations (new way) instead of continuously (old way) resolve methods and its parameters via reflection. - There's a lot of changes as this resolution via reflection had its hooks almost everywhere and thus most changes are just refactorings. - Order to understand real changes I'd start to look classes under `org.springframework.shell.command` package as it defines new registration, catalog and parser classes. Also samples contain new classes to demonstrate new functionality. - Fixes spring-projects#380
One trouble in #379 when I started to implement it is that while it's easy to make
CommandRegistry
writable and register new methods based onMethodTarget
this process from a user perspective is a bit cumbersome.Essentially we still need to make custom pojo:
and have those methods with dummy
@ShellMethod
forStandardParameterResolver
to read parameters.The text was updated successfully, but these errors were encountered: