Skip to content

Default values not used correctly #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue May 11, 2022 · 0 comments · Fixed by #410
Closed

Default values not used correctly #409

jvalkeal opened this issue May 11, 2022 · 0 comments · Fixed by #410
Milestone
2.1.0-M4

Comments

@jvalkeal
Copy link
Contributor

With a recent rework for command structure, options default values don't work correctly including use of @ShellOption.
@jvalkeal jvalkeal added this to the 2.1.0-M4 milestone May 11, 2022
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue May 11, 2022
@jvalkeal
Fix use of default values
89b003c 
- Change parsing to extract and use option default value
  and also hook it with @ShellOption.
- Fixes spring-projects#409
@jvalkeal jvalkeal mentioned this issue May 11, 2022
Merged
jvalkeal added a commit that referenced this issue May 11, 2022
@jvalkeal
Fix use of default values
75ff6e9 
- Change parsing to extract and use option default value
  and also hook it with @ShellOption.
- Fixes #409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0-M4
Development

Successfully merging a pull request may close this issue.

Fix use of default values jvalkeal/spring-shell
1 participant
@jvalkeal