Skip to content

Better errors with non-interactive mode #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue May 26, 2022 · 0 comments · Fixed by #428
Closed

Better errors with non-interactive mode #427

jvalkeal opened this issue May 26, 2022 · 0 comments · Fixed by #428
Milestone
2.1.0-M4

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented May 26, 2022 •
edited
Loading

Exceptions in interactive mode is easy to show as context/shell is alive, not so much with non-interactive. So one options would be to behave differently depending on a mode like printing stacktrace to teminal output on non-interactive. That way user gets useful errors immediately.
@jvalkeal jvalkeal added this to the 2.1.0-RC1 milestone May 26, 2022
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue May 27, 2022
@jvalkeal
Better errors with non-interactive mode
0e399ad 
- Change how errors are printed for interactive
  vs non-interactive mode.
- This now changes behaviour so that stacktrace is printed
  if non-interactive mode is active so that user has a change
  to see the full error.
- Fixes spring-projects#427
@jvalkeal jvalkeal mentioned this issue May 27, 2022
Merged
@jvalkeal jvalkeal modified the milestones: 2.1.0-RC1, 2.1.0-M4 May 27, 2022
jvalkeal added a commit that referenced this issue May 27, 2022
@jvalkeal
Better errors with non-interactive mode
9779b5c 
- Change how errors are printed for interactive
  vs non-interactive mode.
- This now changes behaviour so that stacktrace is printed
  if non-interactive mode is active so that user has a change
  to see the full error.
- Fixes #427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0-M4
Development

Successfully merging a pull request may close this issue.

Better errors with non-interactive mode jvalkeal/spring-shell
1 participant
@jvalkeal