Skip to content

Switch to gradle #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvalkeal opened this issue Jul 19, 2022 · 1 comment
Closed

Switch to gradle #470

jvalkeal opened this issue Jul 19, 2022 · 1 comment
Milestone

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Jul 19, 2022

Once main is switched to 3.0.x we should start a work to add gradle build to get some modern tooling for this project. After gradle build is working we can switch over.

@jvalkeal jvalkeal added this to the 3.0.0-M1 milestone Jul 19, 2022
@jvalkeal jvalkeal changed the title Switch from maven to gradle Switch to gradle Jul 24, 2022
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 16, 2022
- First set of changes for introduction of a gradle build.
- Relates spring-projects#470
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 16, 2022
- First set of changes for introduction of a gradle build.
- Relates spring-projects#470
jvalkeal added a commit that referenced this issue Aug 16, 2022
jvalkeal added a commit that referenced this issue Aug 16, 2022
jvalkeal added a commit that referenced this issue Aug 16, 2022
jvalkeal added a commit that referenced this issue Aug 16, 2022
@jvalkeal
Copy link
Contributor Author

Basic work is now complete.

jvalkeal added a commit that referenced this issue Aug 17, 2022
- Looks like if plain deps are not defined as constraints test
  deps will leak into a fatjar build i.e. with sample.
- Change it how its done in spring security where this idea
  was taken.
- Remove use of maven-publish plugin which is not needed.
- Relates #470
jvalkeal added a commit that referenced this issue Aug 17, 2022
- This adds a way to build native binary for a sample which
  were missed from original gradle work.
- Relates #470
jvalkeal added a commit that referenced this issue Aug 17, 2022
- Fix e2e workflow to build with gradle.
- Fix e2e paths to ones generated by gradle.
- Relates #470
jvalkeal added a commit that referenced this issue Aug 17, 2022
- e2e tests version command fails without build-info.
- Relates #470
jvalkeal added a commit that referenced this issue Aug 17, 2022
- Looks like with gradle we don't get automatic utf-8 encoding with compiler
  so add it and same time use separate JavaConventions as we want to
  apply it to modules and samples.
- Relates #470
jvalkeal added a commit that referenced this issue Sep 6, 2022
- Now switching to use implementation configuration as it
  works better with aot tooling.
- Relates #470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant