We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello. This code always asks for a second input ("skill") in spite of the "next" set to null.
ComponentFlow.ComponentFlowResult run = componentFlowBuilder.clone().reset() .withSingleItemSelector("hero") .selectItems(heroes) .max(10) .next(x -> null) .and() .withSingleItemSelector("skill") .selectItems(skills) .max(10) .and() .build().run();
And in https://docs.spring.io/spring-shell/docs/2.1.1/site/reference/htmlsingle/#using-shell-components-flow It is expected to break the sequence and finish. At least that can be understood from the code, as there is no explanation for the logic in the docs.
The text was updated successfully, but these errors were encountered:
Fix next handling in ComponentFlow
5024982
- This fixes a bug where returning null from a next() didn't stop a flow. - Fixes spring-projects#510
7c4700b
2cf7123
- This fixes a bug where returning null from a next() didn't stop a flow. - Backport #510 - Fixes #513 (cherry picked from commit 7c4700b)
Successfully merging a pull request may close this issue.
Hello.
This code always asks for a second input ("skill") in spite of the "next" set to null.
And in
https://docs.spring.io/spring-shell/docs/2.1.1/site/reference/htmlsingle/#using-shell-components-flow
It is expected to break the sequence and finish. At least that can be understood from the code, as there is no explanation for the logic in the docs.
The text was updated successfully, but these errors were encountered: