Skip to content

backport(602) CommandParser unrecognised option support #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Jan 6, 2023 · 0 comments
Closed

backport(602) CommandParser unrecognised option support #604

jvalkeal opened this issue Jan 6, 2023 · 0 comments
Labels
type/backport Is a issue to track backport, use with branch/xxx
Milestone
2.1.5

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Jan 6, 2023

Backport #602
@jvalkeal jvalkeal added the type/backport Is a issue to track backport, use with branch/xxx label Jan 6, 2023
@jvalkeal jvalkeal added this to the 2.1.5 milestone Jan 6, 2023
jvalkeal added a commit that referenced this issue Jan 7, 2023
@jvalkeal
Add unrecognised option support
38acd79 
- This commit modifies CommandParser to better track positional parameters
  which previously used to go there for non-recognised options. Now using
  relatively dump logic of just checking if first positional parameter starts
  with '-' which indicates it's a candidate for a new `UnrecognisedOptionException`
  which then would give user an error "Unrecognised option '--xxx'" for example.
- Backport #601
- Backport #602
- Fixes #603
- Fixes #604
@jvalkeal jvalkeal closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/backport Is a issue to track backport, use with branch/xxx
Projects
None yet
Milestone
2.1.5
Development

No branches or pull requests
1 participant
@jvalkeal