Question for Arity

[eubnara]

According to "current" document, it seems to take multiple values separated by spaces when specifying arity.
However, with version 2.1.4, it only takes multiple values if it is separated by comma.

Examples are gone on the 2.1.4 documentation. (https://docs.spring.io/spring-shell/docs/2.1.4/site/reference/htmlsingle/#using-shell-options-arity)

Is it expected behavior that it does not allow to get multiple values separated by spaces?
I guess this commit(7042d1f) impacts on this behavor.

[jvalkeal]

Thanks pointing this out! Now that I tried it myself it's indeed caused not-so-great handling of position parameters vs. parsing option type, vs. type conversions.

We really need to revisit this area so that it works properly.

[jvalkeal]

Issues #614 and #616 contains fixes and got backported to 2.1.x. There's also changes in docs.

This is in samples:

spring-shell/spring-shell-samples/src/main/java/org/springframework/shell/samples/e2e/ArityCommands.java

Lines 92 to 97 in 448c507

	@ShellMethod(key = LEGACY_ANNO + "arity-float-array", group = GROUP)
	public String testArityFloatArrayLegacyAnnotation(
	@ShellOption(value = "--arg1", arity = 3) float[] arg1
	) {
	return "Hello " + floatsToString(arg1);
	}

If you want to try then need to pick snapshots.

[jvalkeal]

Closing as I think it's handled with previous commits.