Skip to content

Error handling may break quit command #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Jan 18, 2023 · 0 comments
Closed

Error handling may break quit command #624

jvalkeal opened this issue Jan 18, 2023 · 0 comments
Assignees
@jvalkeal
Labels
type/bug Is a bug report
Milestone
3.0.0

Comments

@jvalkeal
Copy link
Contributor

Currently we rely on ExitRequest from Quit command to break from a run loop. If error handling handles this exception we don't get out from a run loop so that interactive shell exits.

Until we get something better for commands to request exit, do not try to handle ExitRequest with error handling.
@jvalkeal jvalkeal added the type/bug Is a bug report label Jan 18, 2023
@jvalkeal jvalkeal added this to the 3.0.0 milestone Jan 18, 2023
@jvalkeal jvalkeal self-assigned this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvalkeal jvalkeal

Labels
type/bug Is a bug report
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@jvalkeal