Skip to content

Collection option type only takes first item #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Jan 19, 2023 · 0 comments
Closed

Collection option type only takes first item #630

jvalkeal opened this issue Jan 19, 2023 · 0 comments
Labels
branch/2.1.x Issue for a branch for/backport For backporting type/bug Is a bug report
Milestone
3.0.0

Comments

@jvalkeal
Copy link
Contributor

Just having List<String> as an option type, parser wrongly results its value to be just first element if for example --arg one two is used. We should get list of both values.

Behaviour should be same as with String[] which is working fine.
@jvalkeal jvalkeal added branch/2.1.x Issue for a branch for/backport For backporting type/bug Is a bug report labels Jan 19, 2023
@jvalkeal jvalkeal added this to the 3.0.0 milestone Jan 19, 2023
@github-actions github-actions bot mentioned this issue Jan 19, 2023
Closed
jvalkeal added a commit that referenced this issue Jan 19, 2023
@jvalkeal
Handle collection types in a parser
1bc26c7 
- Handle any option collection type so that list is generated for
  values, this then works well when actual type conversions happen.
- Backport #630
- Fixes #631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/2.1.x Issue for a branch for/backport For backporting type/bug Is a bug report
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@jvalkeal