Skip to content

@CommandScan Annotation #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #637
jvalkeal opened this issue Jan 25, 2023 · 1 comment
Closed
Tracked by #637

@CommandScan Annotation #641

jvalkeal opened this issue Jan 25, 2023 · 1 comment
Milestone
3.1.0-M1

Comments

@jvalkeal
Copy link
Contributor

We would not do full classpath scan anymore, instead force user to define targets to scan. Scan is optional and other option is then @EnableCommand.

For example:

@CommandScan(basePackages = "org.example.commands" )
public class App {}

On default scan would happen from a package where annotation is used.

@CommandScan
public class App {}
@jvalkeal jvalkeal modified the milestone: 3.1.0-M1 Jan 25, 2023
@jvalkeal jvalkeal mentioned this issue Jan 25, 2023
Closed
7 tasks
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Jan 27, 2023
@jvalkeal
New annotation model
de1a3ba 
- This is a first commit to add new annotation model
  which eventually will replace old legacy annotations
  like ShellComponent, ShellMethod, @ShellOption, etc.
- Adds subset of features needed for parity with manual
  use of CommandRegistration.
- Relates spring-projects#637
- Relates spring-projects#638
- Relates spring-projects#639
- Relates spring-projects#640
- Relates spring-projects#641
@jvalkeal
Copy link
Contributor Author

jvalkeal commented Feb 8, 2023

Closing as this works fine.

@jvalkeal jvalkeal closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0-M1
Development

No branches or pull requests
1 participant
@jvalkeal