Skip to content

CommandRegistration should return same options #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Jan 28, 2023 · 0 comments
Closed

CommandRegistration should return same options #648

jvalkeal opened this issue Jan 28, 2023 · 0 comments
Assignees
@jvalkeal
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request
Milestone
3.1.0-M1

Comments

@jvalkeal
Copy link
Contributor

CommandRegistration getOptions() will always rebuild options which makes it difficult to know if CommandOption is same instance. Caching these options works better as these are not expected to change.
@jvalkeal jvalkeal added branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request labels Jan 28, 2023
@jvalkeal jvalkeal added this to the 3.1.0-M1 milestone Jan 28, 2023
@jvalkeal jvalkeal self-assigned this Jan 28, 2023
This was referenced Jan 28, 2023
Closed
Closed
jvalkeal added a commit that referenced this issue Jan 28, 2023
@jvalkeal
CommandRegistration should return same options
88df6cc 
- Cache created CommandOption(s) to return same instance.
- Backport #648
- Fixes #650
jvalkeal added a commit that referenced this issue Jan 28, 2023
@jvalkeal
CommandRegistration should return same options
ca76a63 
- Cache created CommandOption(s) to return same instance.
- Backport #648
- Fixes #649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvalkeal jvalkeal

Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request
Projects
None yet
Milestone
3.1.0-M1
Development

No branches or pull requests
1 participant
@jvalkeal