Skip to content

ShellContext not passed to CommandCatalog #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Apr 6, 2023 · 0 comments
Closed

ShellContext not passed to CommandCatalog #702

jvalkeal opened this issue Apr 6, 2023 · 0 comments
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting
Milestone
3.1.0-M2

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Apr 6, 2023

Issue for PR #693.

Essentially 8a23518 refactoring commit removed use of context so that interactive commands ended up showing with non-interactive help command.
@jvalkeal jvalkeal added this to the 3.1.0-M2 milestone Apr 6, 2023
@jvalkeal jvalkeal added for/backport For backporting branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch labels Apr 6, 2023
This was referenced Apr 6, 2023
Closed
Closed
jvalkeal pushed a commit that referenced this issue Apr 6, 2023
@cachescrubber @jvalkeal
Pass ShellContext to CommandCatalog.of in CommandCatalogAutoConfigura…
5ff6c40 
…tion (#693)

- Backport #702
- Fixes #704
jvalkeal pushed a commit that referenced this issue Apr 6, 2023
@cachescrubber @jvalkeal
Pass ShellContext to CommandCatalog.of in CommandCatalogAutoConfigura…
f3e3061 
…tion (#693)

- Backport #702
- Fixes #703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting
Projects
None yet
Milestone
3.1.0-M2
Development

No branches or pull requests
1 participant
@jvalkeal