Skip to content

ConfirmationInput does not show the option selected when typing #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tincore opened this issue May 13, 2023 · 1 comment
Closed

ConfirmationInput does not show the option selected when typing #740

tincore opened this issue May 13, 2023 · 1 comment
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/bug Is a bug report
Milestone

Comments

@tincore
Copy link

tincore commented May 13, 2023

Both v3.0.3 and 3.1.0-RC1

Not sure if I'm doing anything wrong but:

When building a component flow and adding confirmation input.

 .withConfirmationInput(INPUT_CONFIRMATION)
                            .name("Confirm?")
                            .defaultValue(false)
                            .and()

When the flow is executed this component renders

? Confirm?  (y/N) 

But when clicking y or n nothing is rendered in the screen. You have to blindly click y or n and then click enter.

For instance if I click n 3 times I get:

? Confirm? (y/N)                                                                                                                                                                                                                   
✖ Sorry, your input is invalid: 'nnn', try again
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label May 13, 2023
@jvalkeal
Copy link
Contributor

Ah yes that is a bad behaviour and you're right it should not need a correct character and then enter.

@jvalkeal jvalkeal added type/bug Is a bug report for/backport For backporting branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch and removed status/need-triage Team needs to triage and take a first look labels May 14, 2023
@jvalkeal jvalkeal added this to the 3.1.0 milestone May 20, 2023
jvalkeal added a commit that referenced this issue May 20, 2023
- Now displaying what user actually inputs
- Backport #740
- Fixes #746
jvalkeal added a commit that referenced this issue May 20, 2023
- Now displaying what user actually inputs
- Backport #740
- Fixes #745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

2 participants