Skip to content

backport(763): Unexpected comma inserted at the end of the parsed message #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Jun 6, 2023 · 1 comment
Closed

backport(763): Unexpected comma inserted at the end of the parsed message #764

github-actions bot opened this issue Jun 6, 2023 · 1 comment
Labels
branch/3.0.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Backport #763
@github-actions github-actions bot added branch/3.0.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx labels Jun 6, 2023
@jvalkeal jvalkeal added this to the 3.0.5 milestone Jun 6, 2023
jvalkeal added a commit that referenced this issue Jun 7, 2023
@jvalkeal
ExtendedDefaultParser should not add empty arguments
af7be31 
- Fixes issue when last "word" is within quotes and
  cursor is at the end of a line which caused empty
  "word" string in an argument list.
- This then caused i.e. string option to have a collection
  as an input(if no arity settings used) and via
  spring conversions a comma were added.
- Backport #763
- Fixes #764
@jvalkeal jvalkeal closed this as completed Jun 7, 2023
jvalkeal added a commit that referenced this issue Jun 12, 2023
@jvalkeal
Revert "ExtendedDefaultParser should not add empty arguments"
304cf4b 
This reverts commit af7be31.

Relates #764
@jvalkeal jvalkeal removed this from the 3.0.5 milestone Jun 12, 2023
@jvalkeal
Copy link
Contributor

Reverted and cleared from milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/3.0.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvalkeal