Skip to content

Theming system for view framework #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #761
jvalkeal opened this issue Jul 22, 2023 · 0 comments
Open
Tracked by #761

Theming system for view framework #824

jvalkeal opened this issue Jul 22, 2023 · 0 comments
Labels
area/components-view Belongs ui view components
Milestone
3.3.x

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Jul 22, 2023 •
edited
Loading

Views has its own settings for UI side for style, colors, et. We have existing theme system for flow components so want to have a distinction for view framework. Ultimately those two should come together but it's better to build this in view framework first and then think about how overall theming gets together.

i.e. Catalog app has a defunct menu selector for a theme.
@jvalkeal jvalkeal added the area/components-view Belongs ui view components label Jul 22, 2023
@jvalkeal jvalkeal added this to the 3.2.x milestone Jul 22, 2023
@jvalkeal jvalkeal mentioned this issue Jul 22, 2023
Open
19 tasks
@jvalkeal jvalkeal modified the milestones: 3.2.x, 3.2.0-M2 Jul 22, 2023
@jvalkeal jvalkeal changed the title Scheme system for view framework Theming system for view framework Aug 3, 2023
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 4, 2023
@jvalkeal
Base theming for views
ef71363 
- Control is now aware of active theme name and resolver.
- Theme some settings in BoxView, ListView and MenuView.
- Overhaul scenario system to make it work with themes.
- Add new "background" StyleSetting.
- Relates spring-projects#824
@jvalkeal jvalkeal modified the milestones: 3.2.0-M2, 3.2.0-RC1 Sep 25, 2023
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Oct 19, 2023
@jvalkeal
Better background handling in themes
8de0ef4 
- Modify view structures so that we're able to
  control background drawing better
- Remove transparent concept from box view
- Add background styles for dialog, menu/status bars
- Relates spring-projects#824
@jvalkeal jvalkeal modified the milestones: 3.2.0-RC1, 3.2.0 Nov 23, 2023
@jvalkeal jvalkeal modified the milestones: 3.2.0, 3.2.x Dec 10, 2023
@jvalkeal jvalkeal modified the milestones: 3.2.x, 3.3.x Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components-view Belongs ui view components
Projects
None yet
Milestone
3.3.x
Development

No branches or pull requests
1 participant
@jvalkeal