Skip to content

Support modal views #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #761
jvalkeal opened this issue Jul 22, 2023 · 0 comments
Closed
Tracked by #761

Support modal views #825

jvalkeal opened this issue Jul 22, 2023 · 0 comments
Labels
area/components-view Belongs ui view components
Milestone
3.2.0-RC1

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Jul 22, 2023 •
edited
Loading

Modal view essentially is something shown atop of existing views. Normal use case is a dialog.

In a catalog app we have "help" -> "about" which should open model view showing something.
@jvalkeal jvalkeal added the area/components-view Belongs ui view components label Jul 22, 2023
@jvalkeal jvalkeal added this to the 3.2.x milestone Jul 22, 2023
@jvalkeal jvalkeal mentioned this issue Jul 22, 2023
Open
19 tasks
@jvalkeal jvalkeal modified the milestones: 3.2.x, 3.2.0-M2 Jul 22, 2023
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 21, 2023
@jvalkeal
Add ViewService interface
5080658 
- Service interface with holds access to modal
  methods. To get used by views which i.e.
  want to show modal dialogs.
- Relates spring-projects#825
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 21, 2023
@jvalkeal
Initial modal integration
29417d4 
- Integrate TerminalUI to ViewService and modals
- New Dialog scenario
- Relates spring-projects#825
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 24, 2023
@jvalkeal
Add about dialog to catalog app
88c1f56 
- Relates spring-projects#825
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Aug 24, 2023
@jvalkeal
Dialog should float
ba5ab1a 
- New WindowView which can be partially atop of background.
- DialogView now extends WindowView
- Change dialog in Catalog sample and Dialog scenario
- Relates spring-projects#825
- Relates spring-projects#855
@jvalkeal jvalkeal modified the milestones: 3.2.0-M2, 3.2.0-RC1 Oct 7, 2023
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Nov 23, 2023
@jvalkeal
Update modal docs
ead34d6 
- Relates spring-projects#825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components-view Belongs ui view components
Projects
None yet
Milestone
3.2.0-RC1
Development

No branches or pull requests
1 participant
@jvalkeal