Skip to content

Upgrade node-pty in e2e tests #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvalkeal opened this issue Nov 7, 2023 · 0 comments · Fixed by #1095
Closed

Upgrade node-pty in e2e tests #921

jvalkeal opened this issue Nov 7, 2023 · 0 comments · Fixed by #1095
Milestone

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Nov 7, 2023

Should go to version 1.0.0.

@fmbenhassine fmbenhassine added this to the 3.4.1 milestone Apr 25, 2025
therepanic pushed a commit to therepanic/spring-shell that referenced this issue May 7, 2025
- Bump node-pty from 0.11.0-beta19 to 1.0.0
- Bump xterm-headless from 4.18.0 to 5.5.0
- Rename xterm-headless to @xterm/headless as per https://www.npmjs.com/package/xterm-headless
- Unpin Python 3.11 in e2e test by reverting commit spring-projects@8097f1e because it's no longer necessary as explained in spring-projects#909 (comment)

- Fixes spring-projects#909
- Fixes spring-projects#921

Signed-off-by: Andrey Litvitski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants