Add non-interactive shell runner customizer #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Jan 31, 2022
| */ | ||
| @Order(DefaultApplicationRunner.PRECEDENCE) | ||
| public class DefaultApplicationRunner implements ShellApplicationRunner { |
There was a problem hiding this comment.
[UNRELATED] I would like to rename this to DefaultShellApplicationRunner for specificity.
There was a problem hiding this comment.
Yeah true, we could do it with this pr.
|
Other than that, I think this looks good! |
* Add test for ShellRunnerAutoConfiguration
onobc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ordering on the ApplicationShellRunner which is different than the order on the DefaultApplicationRunner. The latter is order that the default runner will execute wrt other application runners. However, the shell runner order is the order that the default app runner will consider them for "1st available to handle the shell".
Refactored the shell runners javadocs to clearly spell out the above and make them consistent w/ the new mechanism (not the enabled property of days old).
Added customizer which allows us to replace the skipper InteractiveApplicationRunner w/ a customizer that simply filters out the non-command args from the
ApplicationArguments(@jvalkeal )This is WIP as I have not added any unit/int testing. I have manually verified the interactive and non-interactive cases in skipper manually though. (spring-attic/spring-cloud-skipper#1026)