Do not include timestamp for buildInfo. #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, reason we have buildinfo is to enable build-in version command. Though samples don't use that field so it can go. Thx, didn't never realise this might happen even if I probably saw that note in boot docs. |
Ah that makes sense. Thanks for the context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a build issue where the build information being generated on each build includes a timestamp. Since the timestamp is incremented each time, no incremental builds will take place for those that tasks that depend on this
buildInfotask.Performance Before Changes Applied
The build scan can be seen here with performance details, with a overall time for executing tasks of 45.650s:
https://scans.gradle.com/s/vgim65zsvbrzm/performance/execution#wall-clock-time
Performance After Changes Applied
Without timestamps being put in the build info, the overall time for executing tasks was 14.763 seconds:
https://scans.gradle.com/s/p5ldndkjxwy4g/performance/execution#wall-clock-time
Some background
The spring boot documentation regarding actually mentions this behavior. Following the link below and looking at the example on excluding the 'time' show the essence of this change.
https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/htmlsingle/#integrating-with-actuator.build-info
@pivotal-cla This is an Obvious Fix