Skip to content

Guard breaks with Throwable #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvalkeal opened this issue Apr 22, 2016 · 3 comments
Closed

Guard breaks with Throwable #206

jvalkeal opened this issue Apr 22, 2016 · 3 comments
Labels
type/bug Is a bug report
Milestone

Comments

@jvalkeal
Copy link
Contributor

If Guard throws error it should evaluate to false. Should catch all exceptions and throwables.

@jvalkeal jvalkeal added the type/bug Is a bug report label Apr 22, 2016
@jvalkeal jvalkeal added this to the 1.1.0.RC1 milestone Apr 22, 2016
@jvalkeal
Copy link
Contributor Author

Looks like simple RuntimeException from Guard didn't break machine, what was usual suspect in #205, but Throwable did break it.

jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Dec 28, 2016
- Just some dependency version issues as
  we didn't get the one in tck tests what
  boot 2.x expects.
- Relates to spring-projects#206
@darknesstm
Copy link

This is really not a good solution

@libinbin880521
Copy link

libinbin880521 commented Jan 6, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

3 participants