An exception in Action causes infinite transition

[miron4dev]

If any exception occurs inside your Action, then Spring State Machine infinitely invokes Action that throws the Exception again.

Server Log:

2017-04-10 19:11:33.450  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.451  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.453  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.454  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.456  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.457  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.459  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.461  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.462  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.464  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>
2017-04-10 19:11:33.466  WARN 17036 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@60db47a8 caused error <Exception Details>

// infinity

In the attached demo, I've prepared simple example to reproduce this issue.
You can invoke deployed REST service using this endpoint http://localhost:8380/doSomething and execute properly configured state machine.
demo.zip

[jvalkeal]

Good catch, this is indeed caused by loop which is needed to follow anonymous transitions and possible error there ended up with infinite loop. I may need to think about how to properly handle this as it's a bit wrong to just stop execution. I'll handle further tweaks in other tickets and fix this loop issue here.

[jvalkeal]

Fixed in 1.2.x per e25c5c6

[miron4dev]

Hello,

The fix partially helped, but now the Action occurs twice.

Server Log:

2017-05-11 18:22:06.061  WARN 20948 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@31441b7e caused error java.lang.NullPointerException: Something was wrong
2017-05-11 18:22:06.062  WARN 20948 --- [nio-8380-exec-1] o.s.s.support.AbstractStateMachine       : Aborting as transition org.springframework.statemachine.transition.DefaultExternalTransition@31441b7e caused error java.lang.NullPointerException: Something was wrong

[jvalkeal]

ok, I'll check it out.

[miron4dev]

Do you have any news about this problem? I can try to analyze the issue and prepare a pull request by myself, if you will check it.

[jvalkeal]

Closing in favour of #384