Skip to content

Change machine lifecycle with restore #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

jvalkeal
Copy link
Contributor

@jvalkeal jvalkeal commented Jul 8, 2017

  • Fixing machine lifecycle logic when machine
    is restored which effectively should not touch
    any lifecycle methods as start/stop is
    user level action.
  • Remove start/stop from restore and attempt to
    do same when root machine is started. This also
    needed some further changes as some functionality
    for restore was essentially broken
  • Fixes Reset may start submachine too early #386

- Fixing machine lifecycle logic when machine
  is restored which effectively should not touch
  any lifecycle methods as start/stop is
  user level action.
- Remove start/stop from restore and attempt to
  do same when root machine is started. This also
  needed some further changes as some functionality
  for restore was essentially broken
- Fixes spring-projects#386
@jvalkeal jvalkeal merged commit 8c18dc8 into spring-projects:1.2.x Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant