draft code for placeholder outside shadow DOM #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at removing the inline styling for the
PlaceholderStyles.tsx
. The approach taken in this PR is one of editing the DOM manually (outside of React's typical Shadow DOM). While still far from a final approach, it's meant as an illustration of how I understood the inline styling problem. You can test this against the Wagtail CMS, and run the bakerydemo (also linked to the Wagtail CMS local repo), for the editing interface.It is an attempt at resolving issue #460
Note:
draftail
test segment completely fails, so I skipped the tests. This will be revisited based on feedback.npm run test:coverage
)npm run lint
)