Build Update #29
Merged
Build Update #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_shared.so from
the ${ANDROID_NDK_ROOT} path.
The copy of libstlport_shared.so is different with the latest NDK release (revision 7)
and the binary .so files are not compatible with the older version of libstlport_shared.so.
Now we should package the libstlport_shared.so available from the build environment.
Note the changes to the Makefile require the ANDROID_NDK_ROOT environment variable be defined.
|
Is the expectation that the build environment will have the latest or specific version of the NDK? Do you think this latest libstlport_shared in compatible back to 2.1? |
|
I believe the expectation should be that android-database-sqlcipher can be built on the NDK it was developed on as well as newer versions of the NDK, this change would allow for both. I have run our internal test suite against builds from the latest NDK (i.e., revision 7) from OS 2.1 - 3.2 without any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request removes the bundled libstlport_shared.so from the root libs/armeabi directory as it is binary incompatible with the latest Android NDK release (e.g., revision 7). Instead we are now copying the version of libstlport_shared.so from the ANDROID_NDK_ROOT build environment that is bundled with the NDK. The Makefile is updated to pull this in and does require the ANDROID_NDK_ROOT environment variable be defined. Let me know if there are any questions. Thanks!
Nick Parker