Skip to content

#8 compatibility dbapi2/sqlite3 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 26, 2024
Merged

Conversation

danielebriggi
Copy link
Member

No description provided.

@danielebriggi danielebriggi added the enhancement New feature or request label Aug 13, 2024
@danielebriggi danielebriggi self-assigned this Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.21595% with 72 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (8c06bac) to head (e703f10).

Files Patch % Lines
...alchemy-sqlitecloud/sqlalchemy_sqlitecloud/base.py 63.01% 27 Missing ⚠️
src/sqlitecloud/dbapi2.py 90.18% 27 Missing ⚠️
src/sqlitecloud/exceptions.py 80.00% 9 Missing ⚠️
src/sqlitecloud/driver.py 91.02% 7 Missing ⚠️
src/tests/integration/test_sqlite_parity.py 99.70% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   96.38%   96.07%   -0.31%     
==========================================
  Files          23       26       +3     
  Lines        2490     3568    +1078     
==========================================
+ Hits         2400     3428    +1028     
- Misses         90      140      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielebriggi danielebriggi changed the title #8 compatibility sqlite3 dbapi2/sqlite33 #8 compatibility sqlite3 dbapi2/sqlite3 Aug 14, 2024
@danielebriggi danielebriggi force-pushed the #8-compatibility-sqlite3-dbapi2 branch 3 times, most recently from e1b97d1 to 368d050 Compare August 16, 2024 08:00
@danielebriggi danielebriggi force-pushed the #8-compatibility-sqlite3-dbapi2 branch 6 times, most recently from 469eb49 to e4ba7a5 Compare August 26, 2024 10:41
@danielebriggi danielebriggi force-pushed the #8-compatibility-sqlite3-dbapi2 branch from e4ba7a5 to 980b961 Compare August 26, 2024 11:01
@danielebriggi danielebriggi changed the title #8 compatibility sqlite3 dbapi2/sqlite3 #8 compatibility dbapi2/sqlite3 Aug 26, 2024
@danielebriggi danielebriggi force-pushed the #8-compatibility-sqlite3-dbapi2 branch from 980b961 to e703f10 Compare August 26, 2024 11:11
@danielebriggi danielebriggi merged commit 94bb910 into main Aug 26, 2024
3 checks passed
@danielebriggi danielebriggi deleted the #8-compatibility-sqlite3-dbapi2 branch August 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants