-
Notifications
You must be signed in to change notification settings - Fork 140
Make the application independent from external CDN when self-hosted #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, I do want to bundle the icons in the executable, but still haven't got to it :) |
I thought I could temporarily override the For the same reason, I can't add Android & iOS PNG favicons either. Don't get me wrong, it already does a lot, but developers always want more 😉 |
Yes, you can override it for your app ! You don't need the Just hardcode |
My bad! It didn't work because I made a mistake in the path. <link rel="stylesheet" href="/css/tabler-icons.min.css"> (it does not handle a custom base path but it's another story) |
icons are now loaded directly from the sqlpage binary instead of loading them from a CDN This makes it possible to host a SQLPage website on an intranet without access to the internet. Fixes #37
Uh oh!
There was an error while loading. Please reload this page.
Currently even with a self-hosted instance on a private area, there are still requests sent outside because of the dependency to
tabler-icons
and Google Fonts.It's hardcoded in
sqlpage/templates/shell.handlebars
so there's no easy way to prevent it, unless overriding the component I guess.https://github.com/lovasoa/SQLpage/blob/9c781dc593c3362b6dd24128d3b8eef744b80509/sqlpage/templates/shell.handlebars#L6-L22
Do you think you could add a way to make all dependencies (current and the ones to come) self-hostable too?
I'm not saying this should be the default behavior, but it would be very handy to have a defined procedure to replace CDN with custom URLs.
The text was updated successfully, but these errors were encountered: