Adding support for use with Go modules #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this patch if you try to run the test of go-git in a Go modules environment, the tests fail due to go-git-fixtures package is not found. In order to found the package on this environment, the build.Context.Import function is leveraged. Signed-off-by: Pablo Andres Fuente <[email protected]>
|
Also I'm wondering if the whole Init() function could be replaced by the code that I added. Theoretically the Import() function should find the correct go-git-fixtures package location, without the need of finding the vendor directories for example. |
|
I am looking into writing a test for a PR against src-d/go-git#1090 and ran into many errors with fixtures because I'm not using a Besides a seemingly unrelated panic in /cc @mcuadros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this patch if you try to run the test of go-git in a Go
modules environment, the tests fail due to go-git-fixtures package is
not found. In order to found the package on this environment, the
build.Context.Import function is leveraged.
Signed-off-by: Pablo Andres Fuente [email protected]