This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Added support for symlink checkouts on Windows #776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts are missing This implementation mimicks the behavior of Git on Windows
mcuadros
suggested changes
Mar 12, 2018
worktree.go
Outdated
| const ERROR_PRIVILEGE_NOT_HELD syscall.Errno = 1314 | ||
|
|
||
| if err != nil { | ||
| if x, ok := err.(*os.LinkError); ok { |
There was a problem hiding this comment.
can you give a proper name to the variable?
worktree.go
Outdated
|
|
||
| if err != nil { | ||
| if x, ok := err.(*os.LinkError); ok { | ||
| if xx, ok := x.Err.(syscall.Errno); ok { |
|
Sorry @fkollmann the "Signed-off-by" is done using the "-s" flag in all the PR commits. |
Signed-off-by: Felix Kollmann <[email protected]>
|
Okay, so every commit has to be signed-off... I will copy the changes to another branch and create a new pull request, later. |
|
Closed in favor of #778 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, elevated rights are required for symlinks.
If they are missing, which is true for almost all users, the library will fail with "A required privilege is not held by the client." (ERROR_PRIVILEGE_NOT_HELD).
This implementation mimics the behavior of Git on Windows.