Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

plumbing: object, return ErrFileNotFound in FindEntry. Fixes #883 #885

Merged
merged 1 commit into from
Jul 16, 2018
Merged

plumbing: object, return ErrFileNotFound in FindEntry. Fixes #883 #885

merged 1 commit into from
Jul 16, 2018

Conversation

jsravn
Copy link
Contributor

@jsravn jsravn commented Jul 5, 2018 •
edited
Loading

FindEntry will return ErrDirNotFound if the directory doesn't exist. But
it doesn't return the corresponding error if the file itself is missing.
This adds the logic to return ErrEntryNotFound, so users can
programmatically check for this condition.

@jsravn
plumbing: object, expose ErrEntryNotFound in FindEntry. Fixes src-d#883
b304997 
FindEntry will return ErrDirNotFound if the directory doesn't exist. But
it doesn't return a public error if the entry itself is missing.  This
exposes the internal error ErrEntryNotFound, so users can
programmatically check for this condition.

Signed-off-by: James Ravn <[email protected]>
@jsravn jsravn force-pushed the findentry-return-file-not-found branch from c75c171 to b304997 Compare July 10, 2018 09:05
@jsravn jsravn mentioned this pull request Jul 10, 2018
Closed
@smola smola requested a review from mcuadros July 12, 2018 08:56
@mcuadros mcuadros merged commit 5b1d537 into src-d:master Jul 16, 2018
@jsravn
Copy link
Contributor Author

jsravn commented Jul 16, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smola smola smola approved these changes

@mcuadros mcuadros Awaiting requested review from mcuadros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsravn @smola @mcuadros