[sqllab] Cancel query to database on query stop #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smacker
changed the title
|
Tested with gitbase rc3 and it works like a charm. |
carlosms
approved these changes
May 30, 2019
superset/superset/sql_lab.py
Outdated
| @@ -193,7 +194,8 @@ def execute_sql_statement(sql_statement, query, user_name, session, cursor): | |||
| db_engine_spec.handle_cursor(cursor, query, session) | |||
|
|
|||
| with stats_timing('sqllab.query.time_fetching_results', stats_logger): | |||
| logging.debug('Fetching data for query object: {}'.format(query.to_dict())) | |||
| logging.debug( | |||
| 'Fetching data for query object: {}'.format(query.to_dict())) | |||
superset/superset/sql_lab.py
Outdated
| @@ -308,9 +313,28 @@ def execute_sql_statements( | |||
| cache_timeout = database.cache_timeout | |||
| if cache_timeout is None: | |||
| cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT', 0) | |||
| results_backend.set(key, zlib_compress(json_payload), cache_timeout) | |||
| results_backend.set(key, zlib_compress( | |||
| json_payload), cache_timeout) | |||
- Add new attribute into Query model that keeps ID of an underlying connection to database for this query - Add `get_connection_id` method to EngineSpec that retrieves connection id for a cursor. - `execute_sql_statements` before executing queries retrieves and saves connection id into Query - Stop handler calls new `cancel_query` method of EngineSpec Both new methods are implemented only for MySQL for now. `cancel_query` uses KILL CONNECTION to terminate the statement. Signed-off-by: Maxim Sukharev <[email protected]>
|
thanks! fixed & rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection to database for this query
get_connection_idmethod to EngineSpec that retrieves connectionid for a cursor.
execute_sql_statementsbefore executing queries retrieves and savesconnection id into Query
cancel_querymethod of EngineSpecBoth new methods are implemented only for MySQL for now.
cancel_queryuses KILL CONNECTION to terminate the statement.Ref: #35