adds support for julia v1 #10
Conversation
|
So great, thanks for putting the work into getting this working! I was actually just thinking yesterday that I missed having it around. Nice idea to use I made a few tweaks and updated the travis/appveyor config - if it passes CI I'll merge and do a release. Thanks again for getting this back up and running! |
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
====================================
- Coverage 100% 92% -8%
====================================
Files 1 1
Lines 45 50 +5
====================================
+ Hits 45 46 +1
- Misses 0 4 +4
Continue to review full report at Codecov.
|
|
Merged and registered for release: JuliaRegistries/General#5209 |
|
Great stuff! Thanks for merging it! 💪🏻 |
…pecific implementation of ssfrr#10, e.g. ``` julia> @testset ExtendedTestSet "begin" begin @test Dict(1 => 2) == Dict(2 => 2) end ===================================================== begin: Test Failed at REPL[5]:2 Expression: Dict(1 => 2) == Dict(2 => 2) Evaluated: Dict(1 => 2) == Dict(2 => 2) <redacted>... ``` This PR will attempt to fix comparing of `Dict`, `Set`, etc while keeping the rest of the vectors and so on working. ``` julia> @testset ExtendedTestSet "begin" begin @test Dict(1 => 2) == Dict(2 => 2) end ===================================================== begin: Test Failed Expression: Dict(1 => 2) == Dict(2 => 2) Diff: Dict( - 1 => 2, + 2 => 2, ) <redacted>... ``` We achieved this by reverting to the implementation before the change. That is, to just evaluate regardless of what the LHS and RHS are in a `@test LHS == RHS` statement. There is one con, which is that `deepdiff` currently doesn't compare everything sufficiently well yet, especially if the objects are not part of the Julia base. This however should be an improvement that we will want to delegate to [DeepDiffs.jl](https://github.com/ssfrr/DeepDiffs.jl), which is good as that gives us a new good reason to help make improvement to that project 💪
Upgraded the codebase to run on Julia v1 - all tests pass.