Skip to content

Add Test as a real dependency #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Add Test as a real dependency #11

merged 1 commit into from
Nov 10, 2019

Conversation

ffevotte
Copy link
Contributor

@ffevotte ffevotte commented Nov 8, 2019

TestSetExtensions currently lists Test as a test-only dependency, which causes  Pkg to complain whenever TestSetExtensions is used in other contexts than its own tests:

julia> using TestSetExtensions
┌ Warning: Package TestSetExtensions does not have Test in its dependencies:- If you have TestSetExtensions checked out for development and have
│   added Test as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with TestSetExtensions
└ Loading Test into TestSetExtensions from project dependency, future warnings for TestSetExtensions are suppressed.

This PR fixes that by simply declaring Test as a standard dependency of TestSetExtensions.

Thanks for this package, and please keep up the good work!

@ffevotte
Copy link
Contributor Author

ffevotte commented Nov 9, 2019

FWIW, it looks like the AppVeyor tests failure is completely unrelated to the changes proposed in this PR.

@ssfrr ssfrr merged commit 0863f89 into ssfrr:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants