feat: Improve editor detection with auto-discovery and better error messages #3155
+30
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GetEditor() utility that checks VISUAL, EDITOR env vars and auto-detects common editors - Support modern editors: VSCode (code), Cursor, Zed, and traditional editors (nvim, vim, nano, vi) - Update /editor and /export commands to use new detection - Provide helpful error message with instructions when no editor found - Support platform-specific defaults (notepad, .cmd extensions on Windows)
affaan-m
force-pushed
the
improve-editor-detection
branch
from
62eaf50 to
4d4640d
Compare
affaan-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the
/editorcommand UX by automatically detecting available editors and providing helpful error messages when none are found.Changes
Add
GetEditor()utility function inpackages/tui/internal/util/util.go:VISUALenvironment variable first (standard for full-screen editors)EDITORenvironment variablecode), Cursor, Zed, Neovim (nvim), Vim, nano, vi.cmdextensions andnotepad.exeon Windows)Update
/editorcommand (EditorOpenCommand) to use new detectionUpdate
/exportcommand (SessionExportCommand) to use new detectionProvide helpful error message: "No editor found. Set EDITOR environment variable (e.g., export EDITOR=vim)"
Testing
Tested scenarios:
Related Issues
Resolves the issue where users get unhelpful "No EDITOR set" message without guidance on how to fix it.