-
-
Notifications
You must be signed in to change notification settings - Fork 23
Implement sqlftw/sqlftw sql parser based type narrowing #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17e0999
to
c14e32d
Compare
staabm
commented
Feb 14, 2023
staabm
commented
Feb 14, 2023
staabm
commented
Feb 14, 2023
staabm
commented
Feb 15, 2023
staabm
commented
Feb 16, 2023
Comment on lines
120
to
121
$parserInference = new ParserInference($this->getSchemaReflection()); | ||
$resultType = $parserInference->narrowResultType($queryString, $resultType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make this inference disabled by default and allow to enable it via RuntimeConfiguration
for now.
reasons
- stabilize
- sqlftw is pretty recent and therefore it should be able to disable it, to make sure we don't run into dead-ends
- sqlftw atm requires php 7.4, so this feature does not work for all versions supported by phpstan-dba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a ugly prototype to do the first steps and learn how sqlftw works.
the PR as narrows the return type of
count()
expressions to0|positive-int
in combination with the native type rangerelevant upstream issues
SimpleName->getFullName()
SQLFTW/sqlftw#16see mysql functions list at https://dev.mysql.com/doc/refman/8.0/en/aggregate-functions.html
Closes #460
Closes #248